]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
udev: log when we fail to query ID_NET_DRIVER
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 9 Nov 2020 14:39:29 +0000 (15:39 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 10 Nov 2020 08:18:53 +0000 (09:18 +0100)
Inspired by #17532.

src/udev/udev-builtin-net_setup_link.c

index ef101381f4649eee7a89693586a59a4ededf41ad..cb12b943fe7d95d04b1e561229be87540a08cc6d 100644 (file)
@@ -19,7 +19,10 @@ static int builtin_net_setup_link(sd_device *dev, int argc, char **argv, bool te
                 return log_device_error_errno(dev, SYNTHETIC_ERRNO(EINVAL), "This program takes no arguments.");
 
         r = link_get_driver(ctx, dev, &driver);
-        if (r >= 0)
+        if (r < 0)
+                log_device_full_errno(dev, r == -EOPNOTSUPP ? LOG_DEBUG : LOG_WARNING,
+                                      r, "Failed to query device driver: %m");
+        else
                 udev_builtin_add_property(dev, test, "ID_NET_DRIVER", driver);
 
         r = link_config_get(ctx, dev, &link);