Add a TOR_DISABLE_PRACTRACKER envvar for use by folks who don't care

Fixes part of bug 30752

diff --git a/Makefile.am b/Makefile.am
index e823f9e10321f67f4ac71cd2449d7acda7394051..d6ea72c17a8ce32c6b066cae91205ba719dc2904 100644 (file)
--- a/Makefile.am
+++ b/Makefile.am
@@ -369,7 +369,9 @@ endif
 
 check-best-practices:
 if USEPYTHON
-       $(PYTHON) $(top_srcdir)/scripts/maint/practracker/practracker.py $(top_srcdir)
+       @if test "$$TOR_DISABLE_PRACTRACKER" = ""; then \
+               $(PYTHON) $(top_srcdir)/scripts/maint/practracker/practracker.py $(top_srcdir); \
+       fi
 endif
 
 practracker-regen:

diff --git a/scripts/maint/practracker/practracker.py b/scripts/maint/practracker/practracker.py
index 75cd44d228c3238dbf4b3945a9f11c0bc565b5a0..70035a0ab63efc2e1330828a1d775229bbe7c754 100755 (executable)
--- a/scripts/maint/practracker/practracker.py
+++ b/scripts/maint/practracker/practracker.py
@@ -227,6 +227,9 @@ Please fix the problems if you can, and update the exceptions file
 ({}) if you can't.
 
 See doc/HACKING/HelpfulTools.md for more information on using practracker.\
+
+You can disable this message by setting the TOR_DISABLE_PRACTRACKER environment
+variable.
 """.format(found_new_issues, exceptions_file)
         print(new_issues_str)