]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ice: fix LAG recipe to profile association
authorMarcin Szycik <marcin.szycik@linux.intel.com>
Fri, 17 Jul 2026 18:53:28 +0000 (11:53 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Jul 2026 16:00:50 +0000 (09:00 -0700)
ice_init_lag() associates recipes to profiles, assuming that Link
Aggregation-related profiles will always have profile ID lower than 70
(ICE_PROFID_IPV6_GTPU_IPV6_TCP_INNER). This value seems arbitrary and
might not always be valid for some versions of DDP package, i.e. LAG
profiles may have profile ID greater than 70. This would lead to
misconfigured switch and LAG not working properly.

Fix it by checking up to maximum profile ID.

Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface")
Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Dave Ertman <david.m.ertman@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Link: https://patch.msgid.link/20260717185340.3595286-7-anthony.l.nguyen@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ice/ice_lag.c

index 310e8fe2925c7d402fdeb8dc633041d6ea116485..08a17ded0ad5566ffdc2b558f2a3c572ee5dc971 100644 (file)
@@ -2623,7 +2623,7 @@ int ice_init_lag(struct ice_pf *pf)
                goto  free_lport_res;
 
        /* associate recipes to profiles */
-       for (n = 0; n < ICE_PROFID_IPV6_GTPU_IPV6_TCP_INNER; n++) {
+       for (n = 0; n < ICE_MAX_NUM_PROFILES; n++) {
                err = ice_aq_get_recipe_to_profile(&pf->hw, n,
                                                   &recipe_bits, NULL);
                if (err)