]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Coverity complains X509_REQ_set_subject_name() return value
authorAlexandr Nedvedicky <sashan@openssl.org>
Thu, 26 Feb 2026 10:21:14 +0000 (11:21 +0100)
committerNeil Horman <nhorman@openssl.org>
Mon, 2 Mar 2026 13:02:56 +0000 (08:02 -0500)
is ignored.

Resolves: https://scan5.scan.coverity.com/#/project-view/62622/10222?selectedIssue=1201538

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
MergeDate: Mon Mar  2 13:03:03 2026
(Merged from https://github.com/openssl/openssl/pull/30193)

apps/ca.c

index c95ef2be4b781a8883b015a61468a7bddbbb5b46..2125ef597dc1433bdb0f91abe05614a333925587 100644 (file)
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -1489,11 +1489,15 @@ static int do_body(X509 **xret, EVP_PKEY *pkey, X509 *x509,
 
     if (subj) {
         X509_NAME *n = parse_name(subj, chtype, multirdn, "subject");
+        int ok_local;
 
         if (!n)
             goto end;
-        X509_REQ_set_subject_name(req, n);
+
+        ok_local = X509_REQ_set_subject_name(req, n);
         X509_NAME_free(n);
+        if (ok_local == 0)
+            goto end;
     }
 
     if (default_op)