]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ptp: ocp: Fix typo using index 1 instead of i in SMA initialization loop
authorJiasheng Jiang <jiashengjiangcool@gmail.com>
Tue, 21 Oct 2025 18:24:56 +0000 (18:24 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2025 13:08:55 +0000 (14:08 +0100)
[ Upstream commit a767957e7a83f9e742be196aa52a48de8ac5a7e4 ]

In ptp_ocp_sma_fb_init(), the code mistakenly used bp->sma[1]
instead of bp->sma[i] inside a for-loop, which caused only SMA[1]
to have its DIRECTION_CAN_CHANGE capability cleared. This led to
inconsistent capability flags across SMA pins.

Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20251021182456.9729-1-jiashengjiangcool@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/ptp/ptp_ocp.c

index efbd80db778d66cc02b041c2c6dbcbb01088da04..bd9919c01e502504f9093d3be716311e536fb398 100644 (file)
@@ -2546,7 +2546,7 @@ ptp_ocp_sma_fb_init(struct ptp_ocp *bp)
                for (i = 0; i < OCP_SMA_NUM; i++) {
                        bp->sma[i].fixed_fcn = true;
                        bp->sma[i].fixed_dir = true;
-                       bp->sma[1].dpll_prop.capabilities &=
+                       bp->sma[i].dpll_prop.capabilities &=
                                ~DPLL_PIN_CAPABILITIES_DIRECTION_CAN_CHANGE;
                }
                return;