hwmon: (max16065) Fix alarm attributes

[ Upstream commit 119abf7d1815f098f7f91ae7abc84324a19943d7 ]

Chips reporting overcurrent alarms report it in the second alarm register.
That means the second alarm register has to be read, even if the chip only
supports 8 or fewer ADC channels.

MAX16067 and MAX16068 report undervoltage and overvoltage alarms in
separate registers. Fold register contents together to report both with
the existing alarm attribute. This requires actually storing the chip type
in struct max16065_data. Rename the variable 'chip' to match the variable
name used in the probe function.

Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Fixes: f5bae2642e3d ("hwmon: Driver for MAX16065 System Manager and compatibles")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/hwmon/max16065.c b/drivers/hwmon/max16065.c
index 072f22f85dc0cce3e9661fcc6d679e9fc9d2e618..b4c519e52fffe49cf67c05f42b882a26aa589697 100644 (file)
--- a/drivers/hwmon/max16065.c
+++ b/drivers/hwmon/max16065.c
@@ -79,7 +79,7 @@ static const bool max16065_have_current[] = {
 };
 
 struct max16065_data {
-       enum chips type;
+       enum chips chip;
        struct i2c_client *client;
        const struct attribute_group *groups[4];
        struct mutex update_lock;
@@ -162,10 +162,17 @@ static struct max16065_data *max16065_update_device(struct device *dev)
                                                     MAX16065_CURR_SENSE);
                }
 
-               for (i = 0; i < DIV_ROUND_UP(data->num_adc, 8); i++)
+               for (i = 0; i < 2; i++)
                        data->fault[i]
                          = i2c_smbus_read_byte_data(client, MAX16065_FAULT(i));
 
+               /*
+                * MAX16067 and MAX16068 have separate undervoltage and
+                * overvoltage alarm bits. Squash them together.
+                */
+               if (data->chip == max16067 || data->chip == max16068)
+                       data->fault[0] |= data->fault[1];
+
                data->last_updated = jiffies;
                data->valid = 1;
        }
@@ -514,6 +521,7 @@ static int max16065_probe(struct i2c_client *client)
        if (unlikely(!data))
                return -ENOMEM;
 
+       data->chip = chip;
        data->client = client;
        mutex_init(&data->update_lock);