Do not allow negative file descriptors to be closed

Especially

diff --git a/backend/lpd.c b/backend/lpd.c
index bc13c6f6bf55d0209af509207a6320f06acf4e7f..6a5f32ad662d693350d402cdca33575be696410d 100644 (file)
--- a/backend/lpd.c
+++ b/backend/lpd.c
@@ -523,7 +523,7 @@ main(int  argc,                             /* I - Number of command-line arguments (6 or 7) */
   if (tmpfilename[0])
     unlink(tmpfilename);
 
-  if (fd)
+  if (fd > 0)
     close(fd);
 
   if (snmp_fd >= 0)
@@ -948,7 +948,7 @@ lpd_queue(const char      *hostname,        /* I - Host to connect to */
     * Next, open the print file and figure out its size...
     */
 
-    if (print_fd)
+    if (print_fd > 0)
     {
      /*
       * Use the size from the print file...

diff --git a/filter/rastertoepson.c b/filter/rastertoepson.c
index 644e81e5e23ad694315cf6b09fe6cae1539951b0..9de398693556314b1d500e0eca656447497f86d1 100644 (file)
--- a/filter/rastertoepson.c
+++ b/filter/rastertoepson.c
@@ -1141,7 +1141,7 @@ main(int  argc,                           /* I - Number of command-line arguments */
   */
 
   cupsRasterClose(ras);
-  if (fd != 0)
+  if (fd > 0)
     close(fd);
 
  /*

diff --git a/filter/rastertohp.c b/filter/rastertohp.c
index d2743b2dd2ec87a3e4af969baa31d828f233c3f9..bb942c35956c9df3d8f2645fabb817acd34007c8 100644 (file)
--- a/filter/rastertohp.c
+++ b/filter/rastertohp.c
@@ -813,7 +813,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
   */
 
   cupsRasterClose(ras);
-  if (fd != 0)
+  if (fd > 0)
     close(fd);
 
  /*

diff --git a/filter/rastertolabel.c b/filter/rastertolabel.c
index 8f75e9a17691a7476fa74e8850f9a84139825fba..e196b8685b5adfbdfb4c9b7b179c870c17057408 100644 (file)
--- a/filter/rastertolabel.c
+++ b/filter/rastertolabel.c
@@ -1263,7 +1263,7 @@ main(int  argc,                           /* I - Number of command-line arguments */
   */
 
   cupsRasterClose(ras);
-  if (fd != 0)
+  if (fd > 0)
     close(fd);
 
  /*

diff --git a/filter/rastertopwg.c b/filter/rastertopwg.c
index 9c50f71a74966e43f8594fd97aa77435329a90c6..6ef0975d257b2c11a8d9370fb1e30c3a35ba8b7c 100644 (file)
--- a/filter/rastertopwg.c
+++ b/filter/rastertopwg.c
@@ -490,7 +490,7 @@ main(int  argc,                             /* I - Number of command-line args */
   }
 
   cupsRasterClose(inras);
-  if (fd)
+  if (fd > 0)
     close(fd);
 
   cupsRasterClose(outras);