]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
pytest: samba_tool domain auth policy fix for SDDL err msg
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 27 Oct 2023 03:14:04 +0000 (16:14 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 1 Nov 2023 20:10:46 +0000 (20:10 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/samba_tool/domain_auth_policy.py
selftest/knownfail.d/samba-tool-sddl-errors [deleted file]

index 9720f788e65d923ffeb116dfaf8e53b24087c3a7..445be2ccec6d0532eebc2f937cd97cf22a543265 100644 (file)
@@ -294,8 +294,8 @@ class AuthPolicyCmdTestCase(BaseAuthCmdTest):
                                        "*INVALID SDDL*")
 
         self.assertEqual(result, -1)
-        self.assertIn(
-            "msDS-UserAllowedToAuthenticateFrom: Unable to parse SDDL", err)
+        self.assertIn("Unable to parse SDDL", err)
+        self.assertIn(" *INVALID SDDL*\n ^\n unknown error", err)
 
     def test_create__already_exists(self):
         """Test creating a new authentication policy that already exists."""
diff --git a/selftest/knownfail.d/samba-tool-sddl-errors b/selftest/knownfail.d/samba-tool-sddl-errors
deleted file mode 100644 (file)
index a1b9e1a..0000000
+++ /dev/null
@@ -1 +0,0 @@
-samba.tests.samba_tool.domain_auth_policy.samba.tests.samba_tool.domain_auth_policy.AuthPolicyCmdTestCase.test_authentication_policy_create_invalid_sddl