]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
phy: Add helper function to check phy interface mode
authorIyappan Subramanian <isubramanian@apm.com>
Thu, 18 May 2017 22:13:43 +0000 (15:13 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 3 Mar 2018 15:52:12 +0000 (15:52 +0000)
commit 32d0f7830d9be5b1652a718e050d808b4908155f upstream.

Added helper function that checks phy_mode is RGMII (all variants)
'bool phy_interface_mode_is_rgmii(phy_interface_t mode)'

Changed the following function, to use the above.
'bool phy_interface_is_rgmii(struct phy_device *phydev)'

Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/linux/phy.h

index 283cebb80443d2383d1136903c9c416de452487a..fd51385d754140ea00e149656c1b872b24ede0c3 100644 (file)
@@ -629,6 +629,17 @@ static inline bool phy_is_internal(struct phy_device *phydev)
        return phydev->is_internal;
 }
 
+/**
+ * phy_interface_mode_is_rgmii - Convenience function for testing if a
+ * PHY interface mode is RGMII (all variants)
+ * @mode: the phy_interface_t enum
+ */
+static inline bool phy_interface_mode_is_rgmii(phy_interface_t mode)
+{
+       return mode >= PHY_INTERFACE_MODE_RGMII &&
+               mode <= PHY_INTERFACE_MODE_RGMII_TXID;
+};
+
 /**
  * phy_interface_is_rgmii - Convenience function for testing if a PHY interface
  * is RGMII (all variants)
@@ -636,8 +647,7 @@ static inline bool phy_is_internal(struct phy_device *phydev)
  */
 static inline bool phy_interface_is_rgmii(struct phy_device *phydev)
 {
-       return phydev->interface >= PHY_INTERFACE_MODE_RGMII &&
-               phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID;
+       return phy_interface_mode_is_rgmii(phydev->interface);
 }
 
 /**