]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/sysfs: Drop redundant runtime PM usage
authorRaag Jadav <raag.jadav@intel.com>
Thu, 18 Sep 2025 11:48:04 +0000 (17:18 +0530)
committerLucas De Marchi <lucas.demarchi@intel.com>
Tue, 30 Sep 2025 14:52:45 +0000 (07:52 -0700)
The device is expected to be in D0 state during driver probe. No need to
resume it in ->is_visible() callbacks or non I/O operations.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://lore.kernel.org/r/20250918114804.2957177-3-raag.jadav@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_device_sysfs.c

index c5151c86a98ae3fdb8bf0213a145c37471df2897..ec9c06b06fb503a94aebe339e9603be4cff7755d 100644 (file)
@@ -38,13 +38,8 @@ vram_d3cold_threshold_show(struct device *dev,
 {
        struct pci_dev *pdev = to_pci_dev(dev);
        struct xe_device *xe = pdev_to_xe_device(pdev);
-       int ret;
-
-       xe_pm_runtime_get(xe);
-       ret = sysfs_emit(buf, "%d\n", xe->d3cold.vram_threshold);
-       xe_pm_runtime_put(xe);
 
-       return ret;
+       return sysfs_emit(buf, "%d\n", xe->d3cold.vram_threshold);
 }
 
 static ssize_t
@@ -173,11 +168,8 @@ static umode_t late_bind_attr_is_visible(struct kobject *kobj,
        u32 cap = 0;
        int ret;
 
-       xe_pm_runtime_get(xe);
-
        ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
                            &cap, NULL);
-       xe_pm_runtime_put(xe);
        if (ret)
                return 0;