ntb_perf: Delete duplicate dmaengine_unmap_put() call in perf_copy_chunk()

commit 4279e72cab31dd3eb8c89591eb9d2affa90ab6aa upstream.

The function call “dmaengine_unmap_put(unmap)” was used in an if branch.
The same call was immediately triggered by a subsequent goto statement.
Thus avoid such a call repetition.

This issue was detected by using the Coccinelle software.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Cc: stable@vger.kernel.org
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
index 5a7a02408166efc487bfe52725aa1d2a314ae859..04690897a067692d9e0b92ecf2092b22af012ccd 100644 (file)
--- a/drivers/ntb/test/ntb_perf.c
+++ b/drivers/ntb/test/ntb_perf.c
@@ -839,10 +839,8 @@ static int perf_copy_chunk(struct perf_thread *pthr,
        dma_set_unmap(tx, unmap);
 
        ret = dma_submit_error(dmaengine_submit(tx));
-       if (ret) {
-               dmaengine_unmap_put(unmap);
+       if (ret)
                goto err_free_resource;
-       }
 
        dmaengine_unmap_put(unmap);