]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: make CAN device follow activation policy
authorYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 29 Apr 2021 22:03:13 +0000 (07:03 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 30 Apr 2021 10:16:15 +0000 (19:16 +0900)
src/network/networkd-can.c

index e448a1ad02c4effea6cdaddf64e494cfe1e56928..787cfd711e7e2acf4f74932e8aaedb99043a3310 100644 (file)
@@ -69,6 +69,12 @@ static int link_set_handler(sd_netlink *rtnl, sd_netlink_message *m, Link *link)
 
         log_link_debug(link, "Link set");
 
+        r = link_activate(link);
+        if (r < 0) {
+                link_enter_failed(link);
+                return 1;
+        }
+
         link->can_configured = true;
         link_check_ready(link);
 
@@ -220,9 +226,6 @@ static int link_set_can(Link *link) {
 
         link_ref(link);
 
-        if (!(link->flags & IFF_UP))
-                return link_up(link);
-
         return 0;
 }
 
@@ -264,13 +267,9 @@ int link_configure_can(Link *link) {
                 return r;
         }
 
-        if (!(link->flags & IFF_UP)) {
-                r = link_up(link);
-                if (r < 0) {
-                        link_enter_failed(link);
-                        return r;
-                }
-        }
+        r = link_activate(link);
+        if (r < 0)
+                return r;
 
         link->can_configured = true;
         link_check_ready(link);