]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tty/vt: Add missing return value for VT_RESIZE in vt_ioctl()
authorZizhi Wo <wozizhi@huaweicloud.com>
Thu, 4 Sep 2025 02:39:55 +0000 (10:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Sep 2025 13:49:55 +0000 (15:49 +0200)
In vt_ioctl(), the handler for VT_RESIZE always returns 0, which prevents
users from detecting errors. Add the missing return value so that errors
can be properly reported to users like vt_resizex().

Signed-off-by: Zizhi Wo <wozizhi@huaweicloud.com>
Link: https://lore.kernel.org/r/20250904023955.3892120-1-wozizhi@huaweicloud.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/vt_ioctl.c

index c9f11c4bd9fe8abcc2bfe571b834b9d348d15641..28993a3d0acb639deec2aabab9c9b92cdd8c98e8 100644 (file)
@@ -908,7 +908,9 @@ int vt_ioctl(struct tty_struct *tty,
 
                        if (vc) {
                                /* FIXME: review v tty lock */
-                               __vc_resize(vc_cons[i].d, cc, ll, true);
+                               ret = __vc_resize(vc_cons[i].d, cc, ll, true);
+                               if (ret)
+                                       return ret;
                        }
                }
                break;