]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-130164: Fix inspect.Signature.bind() handling of positional-only args without...
authorJacob Walls <jacobtylerwalls@gmail.com>
Tue, 18 Feb 2025 15:19:04 +0000 (10:19 -0500)
committerGitHub <noreply@github.com>
Tue, 18 Feb 2025 15:19:04 +0000 (17:19 +0200)
Follow-up to 9c15202.

Lib/inspect.py
Lib/test/test_inspect/test_inspect.py
Misc/NEWS.d/next/Library/2025-02-16-08-56-48.gh-issue-130164.vvoaU2.rst [new file with mode: 0644]

index facad478103668c4051065c620a968fb772d6e3f..124293727ca84a8c8e03739a6dac01cd110ed873 100644 (file)
@@ -3077,6 +3077,9 @@ class Signature:
                         break
                     elif param.name in kwargs:
                         if param.kind == _POSITIONAL_ONLY:
+                            if param.default is _empty:
+                                msg = f'missing a required positional-only argument: {param.name!r}'
+                                raise TypeError(msg)
                             # Raise a TypeError once we are sure there is no
                             # **kwargs param later.
                             pos_only_param_in_kwargs.append(param)
index 8e47df21cfef2e84128d639c8d7fa833fa1759d8..06785e275f6b118e957bd688cb364460f69bd08a 100644 (file)
@@ -5149,7 +5149,11 @@ class TestSignatureBind(unittest.TestCase):
     def call(func, *args, **kwargs):
         sig = inspect.signature(func)
         ba = sig.bind(*args, **kwargs)
-        return func(*ba.args, **ba.kwargs)
+        # Prevent unexpected success of assertRaises(TypeError, ...)
+        try:
+            return func(*ba.args, **ba.kwargs)
+        except TypeError as e:
+            raise AssertionError from e
 
     def test_signature_bind_empty(self):
         def test():
@@ -5349,7 +5353,7 @@ class TestSignatureBind(unittest.TestCase):
         self.assertEqual(self.call(test, 1, 2, c_po=4),
                          (1, 2, 3, 42, 50, {'c_po': 4}))
 
-        with self.assertRaisesRegex(TypeError, "missing 2 required positional arguments"):
+        with self.assertRaisesRegex(TypeError, "missing a required positional-only argument: 'a_po'"):
             self.call(test, a_po=1, b_po=2)
 
         def without_var_kwargs(c_po=3, d_po=4, /):
diff --git a/Misc/NEWS.d/next/Library/2025-02-16-08-56-48.gh-issue-130164.vvoaU2.rst b/Misc/NEWS.d/next/Library/2025-02-16-08-56-48.gh-issue-130164.vvoaU2.rst
new file mode 100644 (file)
index 0000000..a4a47cb
--- /dev/null
@@ -0,0 +1,3 @@
+Fixed failure to raise :exc:`TypeError` in :meth:`inspect.Signature.bind`
+for positional-only arguments provided by keyword when a variadic keyword
+argument (e.g. ``**kwargs``) is present.