]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-device: check the validity of device id
authorYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 9 Mar 2021 07:11:52 +0000 (16:11 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 30 Apr 2021 10:21:18 +0000 (19:21 +0900)
The device id is used as filename under /run/udev/data or
/run/udev/watch.

src/libsystemd/sd-device/sd-device.c

index decf9ae1d1c9446c045877cffa81a4f0da3b2c34..233bb6df5d2b9a70a7d42804ba6a4133a9e76ac2 100644 (file)
@@ -1306,6 +1306,9 @@ int device_get_device_id(sd_device *device, const char **ret) {
                                 return -ENOMEM;
                 }
 
+                if (!filename_is_valid(id))
+                        return -EINVAL;
+
                 device->device_id = TAKE_PTR(id);
         }