Note that circuit purpose changing can violate ExcludeNodes

diff --git a/src/or/rendservice.c b/src/or/rendservice.c
index 88f1ba3dddf8138cb58c8e6747b59e6c63ab5c70..5b85394ddc7629662fa5d0bf3529b69044731059 100644 (file)
--- a/src/or/rendservice.c
+++ b/src/or/rendservice.c
@@ -1352,6 +1352,9 @@ rend_service_intro_has_opened(origin_circuit_t *circuit)
     log_info(LD_CIRC|LD_REND, "We have just finished an introduction "
              "circuit, but we already have enough. Redefining purpose to "
              "general.");
+    /* XXX022-1090: This can wind up violating ExcludeNodes/
+     * ExitNodes/ExcludeExitNodes restrictions.
+     */
     TO_CIRCUIT(circuit)->purpose = CIRCUIT_PURPOSE_C_GENERAL;
     circuit_has_opened(circuit);
     return;