]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-138489: Add missing `build-details.json` step for building wasm (#139302)
authorHo Kim <ho.kim@ulagbulag.io>
Sat, 4 Oct 2025 13:26:20 +0000 (22:26 +0900)
committerGitHub <noreply@github.com>
Sat, 4 Oct 2025 13:26:20 +0000 (14:26 +0100)
* fix: add missing `build-details.json` step for building wasm

Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
* gh-138489: Add missing build-details.json step for building wasm

Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
* Update Makefile.pre.in

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
---------

Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Makefile.pre.in
Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst [new file with mode: 0644]

index 6651b093e20c8dc8781607189bc1acc1d0e449ad..37bde125166f817897d906ad826005532c53070f 100644 (file)
@@ -801,7 +801,7 @@ build_all:  check-clean-src check-app-store-compliance $(BUILDPYTHON) platform sh
 
 .PHONY: build_wasm
 build_wasm: check-clean-src $(BUILDPYTHON) platform sharedmods \
-               python-config checksharedmods
+               python-config checksharedmods build-details.json
 
 .PHONY: build_emscripten
 build_emscripten: build_wasm web_example web_example_pyrepl_jspi
diff --git a/Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst b/Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst
new file mode 100644 (file)
index 0000000..b11098a
--- /dev/null
@@ -0,0 +1,6 @@
+When cross-compiling for WASI by ``build_wasm`` or ``build_emscripten``, the
+``build-details.json`` step is now included in the build process, just like
+with native builds.
+
+This fixes the ``libinstall`` task which requires the ``build-details.json``
+file during the process.