]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
pidl: Remove unneeded casts
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Wed, 22 Nov 2023 02:24:55 +0000 (15:24 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 30 Nov 2023 00:02:33 +0000 (00:02 +0000)
_pytalloc_get_ptr() returns ‘void *’.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
pidl/lib/Parse/Pidl/Samba4/Python.pm

index 2f2574338595eaa1827bc78aee88706864dda069..1955b88f48f3bd9b079cb644af04d25c81cbaaf8 100644 (file)
@@ -169,7 +169,7 @@ sub PythonElementGetSet($$$$$$) {
        $self->pidl("static PyObject *py_$name\_get_$e->{NAME}(PyObject *obj, void *closure)");
        $self->pidl("{");
        $self->indent;
-       $self->pidl("$cname *object = ($cname *)pytalloc_get_ptr(obj);");
+       $self->pidl("$cname *object = pytalloc_get_ptr(obj);");
        $self->pidl("PyObject *py_$e->{NAME};");
        my $l = $e->{LEVELS}[0];
        if ($l->{TYPE} eq "POINTER") {
@@ -188,7 +188,7 @@ sub PythonElementGetSet($$$$$$) {
        $self->pidl("static int py_$name\_set_$e->{NAME}(PyObject *py_obj, PyObject *value, void *closure)");
        $self->pidl("{");
        $self->indent;
-       $self->pidl("$cname *object = ($cname *)pytalloc_get_ptr(py_obj);");
+       $self->pidl("$cname *object = pytalloc_get_ptr(py_obj);");
        my $mem_ctx = "pytalloc_get_mem_ctx(py_obj)";
        my $nl = GetNextLevel($e, $l);
        if ($l->{TYPE} eq "POINTER" and
@@ -259,7 +259,7 @@ sub PythonStruct($$$$$$)
                $self->pidl("static PyObject *py_$name\_ndr_pack(PyObject *py_obj,  PyObject *Py_UNUSED(ignored))");
                $self->pidl("{");
                $self->indent;
-               $self->pidl("$cname *object = ($cname *)pytalloc_get_ptr(py_obj);");
+               $self->pidl("$cname *object = pytalloc_get_ptr(py_obj);");
                $self->pidl("PyObject *ret = NULL;");
                $self->pidl("DATA_BLOB blob;");
                $self->pidl("enum ndr_err_code err;");
@@ -289,7 +289,7 @@ sub PythonStruct($$$$$$)
                $self->pidl("static PyObject *py_$name\_ndr_unpack(PyObject *py_obj, PyObject *args, PyObject *kwargs)");
                $self->pidl("{");
                $self->indent;
-               $self->pidl("$cname *object = ($cname *)pytalloc_get_ptr(py_obj);");
+               $self->pidl("$cname *object = pytalloc_get_ptr(py_obj);");
                $self->pidl("DATA_BLOB blob = {.data = NULL, .length = 0};");
                $self->pidl("Py_ssize_t blob_length = 0;");
                $self->pidl("enum ndr_err_code err;");
@@ -339,7 +339,7 @@ sub PythonStruct($$$$$$)
                $self->pidl("static PyObject *py_$name\_ndr_print(PyObject *py_obj, PyObject *Py_UNUSED(ignored))");
                $self->pidl("{");
                $self->indent;
-               $self->pidl("$cname *object = ($cname *)pytalloc_get_ptr(py_obj);");
+               $self->pidl("$cname *object = pytalloc_get_ptr(py_obj);");
                $self->pidl("PyObject *ret;");
                $self->pidl("char *retstr;");
                $self->pidl("");
@@ -531,7 +531,7 @@ sub PythonFunctionStruct($$$$)
        my $py_methods = "NULL";
 
        my $ndr_call = "const struct ndr_interface_call *call = NULL;";
-       my $object_ptr = "$cname *object = ($cname *)pytalloc_get_ptr(py_obj);";
+       my $object_ptr = "$cname *object = pytalloc_get_ptr(py_obj);";
 
        $self->pidl("static PyObject *py_$name\_ndr_opnum(PyTypeObject *type, PyObject *Py_UNUSED(ignored))");
        $self->pidl("{");