]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests: mptcp: join: mark 'delete re-add signal' as skipped if not supported
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Mon, 27 Oct 2025 14:22:12 +0000 (10:22 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 2 Nov 2025 13:15:22 +0000 (22:15 +0900)
[ Upstream commit c3496c052ac36ea98ec4f8e95ae6285a425a2457 ]

The call to 'continue_if' was missing: it properly marks a subtest as
'skipped' if the attached condition is not valid.

Without that, the test is wrongly marked as passed on older kernels.

Fixes: b5e2fb832f48 ("selftests: mptcp: add explicit test case for remove/readd")
Cc: stable@vger.kernel.org
Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20251020-net-mptcp-c-flag-late-add-addr-v1-4-8207030cb0e8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/net/mptcp/mptcp_join.sh

index 9016bfb120845b30b541f4e4648e2755fe828536..ec7547bdda89f6196a6cf52431f4ebd6b0ba8b5f 100755 (executable)
@@ -3823,7 +3823,7 @@ endpoint_tests()
 
        # remove and re-add
        if reset_with_events "delete re-add signal" &&
-          mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
+          continue_if mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
                ip netns exec $ns1 sysctl -q net.mptcp.add_addr_timeout=0
                pm_nl_set_limits $ns1 0 3
                pm_nl_set_limits $ns2 3 3