Bug 2391: assertion failed: forward.cc:1209: "(fs->code == HIER_DIRECT) == !fs->_peer"

assert was wrong.

diff --git a/src/forward.cc b/src/forward.cc
index 70efc25a880d917a1e16f01d93840a5bfaeeacf9..fd923aba652943603ec6ee8f1a8022d68e26c747 100644 (file)
--- a/src/forward.cc
+++ b/src/forward.cc
@@ -1224,12 +1224,9 @@ FwdState::updateHierarchyInfo()
     FwdServer *fs = servers;
     assert(fs);
 
-    // some callers use one condition, some use the other; are they the same?
-    assert((fs->code == HIER_DIRECT) == !fs->_peer);
-
     const char *nextHop = NULL;
 
-    if (fs->_peer) { 
+    if (fs->_peer) {
         // went to peer, log peer host name
         nextHop = fs->_peer->name;
     } else {
@@ -1240,7 +1237,7 @@ FwdState::updateHierarchyInfo()
         nextHop = fd_table[server_fd].ipaddr;
         if (!Config.onoff.log_ip_on_direct || !nextHop[0])
             nextHop = request->GetHost(); // domain name
-       }
+    }
 
     assert(nextHop);
     hierarchyNote(&request->hier, fs->code, nextHop);