]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
octeontx2-af: devlink: fix NIX RAS reporter recovery condition
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Tue, 10 Mar 2026 18:48:16 +0000 (11:48 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Mar 2026 03:39:19 +0000 (20:39 -0700)
The NIX RAS health reporter recovery routine checks nix_af_rvu_int to
decide whether to re-enable NIX_AF_RAS interrupts. This is the RVU
interrupt status field and is unrelated to RAS events, so the recovery
flow may incorrectly skip re-enabling NIX_AF_RAS interrupts.

Check nix_af_rvu_ras instead before writing NIX_AF_RAS_ENA_W1S.

Fixes: 5ed66306eab6 ("octeontx2-af: Add devlink health reporters for NIX")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://patch.msgid.link/20260310184824.1183651-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c

index fb15c794efc9f4f3eb3dc9cdb2f082b9ef0f80ff..7ef3da0f6a885f7b86c8666c773ebe53b26fbc8b 100644 (file)
@@ -475,7 +475,7 @@ static int rvu_hw_nix_ras_recover(struct devlink_health_reporter *reporter,
        if (blkaddr < 0)
                return blkaddr;
 
-       if (nix_event_ctx->nix_af_rvu_int)
+       if (nix_event_ctx->nix_af_rvu_ras)
                rvu_write64(rvu, blkaddr, NIX_AF_RAS_ENA_W1S, ~0ULL);
 
        return 0;