]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: dvbdev: Initialize sbuf
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 25 Mar 2024 14:50:25 +0000 (14:50 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jul 2024 07:08:28 +0000 (09:08 +0200)
[ Upstream commit 17d1316de0d7dc1bdc5d6e3ad4efd30a9bf1a381 ]

Because the size passed to copy_from_user() cannot be known beforehand,
it needs to be checked during runtime with check_object_size. That makes
gcc believe that the content of sbuf can be used before init.

Fix:
./include/linux/thread_info.h:215:17: warning: ‘sbuf’ may be used uninitialized [-Wmaybe-uninitialized]

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/dvb-core/dvbdev.c

index d4d903a9dc31ee58b31e0617538c33e0baecd037..ba91c6f8fe1d8dc401bf9b5c9f34569dcc68fd63 100644 (file)
@@ -974,7 +974,7 @@ int dvb_usercopy(struct file *file,
                     int (*func)(struct file *file,
                     unsigned int cmd, void *arg))
 {
-       char    sbuf[128];
+       char    sbuf[128] = {};
        void    *mbuf = NULL;
        void    *parg = NULL;
        int     err  = -EINVAL;