curl: improved cleanup in upload error path

Memory leak found by torture test 58

Closes #4705

diff --git a/src/tool_operhlp.c b/src/tool_operhlp.c
index 543bf430256d9db7ea9ca0487313382ac628f3d3..8a9b7c9e8fd3557fec1669f7a726fc3dca213abc 100644 (file)
--- a/src/tool_operhlp.c
+++ b/src/tool_operhlp.c
@@ -115,16 +115,17 @@ char *add_file_name_to_url(char *url, const char *filename)
         urlbuffer = aprintf("%s/%s", url, encfile);
 
       curl_free(encfile);
-      Curl_safefree(url);
 
-      if(!urlbuffer)
-        return NULL;
+      if(!urlbuffer) {
+        url = NULL;
+        goto end;
+      }
 
+      Curl_safefree(url);
       url = urlbuffer; /* use our new URL instead! */
     }
-    else
-      Curl_safefree(url);
   }
+  end:
   curl_easy_cleanup(curl);
   return url;
 }