]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[2027] update rationale comment about acl check
authorJelte Jansen <jelte@isc.org>
Fri, 15 Jun 2012 07:51:27 +0000 (09:51 +0200)
committerJelte Jansen <jelte@isc.org>
Fri, 15 Jun 2012 07:51:27 +0000 (09:51 +0200)
src/lib/python/isc/ddns/session.py

index 5cadb60acb42fe7785057211389de9f101878be3..366bc8b75f9f4c17a8ba5a5c2cd859213e8af2b6 100644 (file)
@@ -243,8 +243,10 @@ class UpdateSession:
         try:
             self._get_update_zone()
             # Contrary to what RFC2136 specifies, we do ACL checks before
-            # prerequisites. Following the spec, information could leak,
-            # and we decided not to do so (as do other implementations)
+            # prerequisites. It's now generally considered to be a bad
+            # idea, and actually does harm such as information
+            # leak. It should make more sense to prevent any security issues
+            # by performing ACL check as early as possible.
             self.__check_update_acl(self.__zname, self.__zclass)
             self._create_diff()
             prereq_result = self.__check_prerequisites()