Second condition was a subset of the first, so hold was never decremented, thus hint...

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49831 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 6664fccda08dc783b3fd976e302818aec558ce06..bb831ad33ce46f1c5955beeffa4a1fb77ec736a3 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -8095,7 +8095,7 @@ static void sip_peer_hold(struct sip_pvt *p, int hold)
        /* If they put someone on hold, increment the value... otherwise decrement it */
        if (hold)
                peer->onHold++;
-       else if (hold > 0)
+       else
                peer->onHold--;
 
        /* Request device state update */