]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nfp: fix simple vNIC mailbox length
authorDirk van der Merwe <dirk.vandermerwe@netronome.com>
Thu, 7 Mar 2019 18:52:13 +0000 (10:52 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:50:31 +0000 (14:50 +0100)
[ Upstream commit eaab2d2d0fe4393b040dbf3922e18cd2ab7d6b85 ]

The simple vNIC mailbox length should be 12 decimal and not 0x12.
Using a decimal also makes it clear this is a length value and not
another field within the simple mailbox defines.

Found by code inspection, there are no known firmware configurations
where this would cause issues.

Fixes: 527d7d1b9949 ("nfp: read mailbox address from TLV caps")
Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h

index 44d3ea75d043a2867fa6ae717535fae80c6a4dd6..ab602a79b084d188baedf30ff3b79e9c0a81ee87 100644 (file)
 #define NFP_NET_CFG_MBOX_SIMPLE_CMD    0x0
 #define NFP_NET_CFG_MBOX_SIMPLE_RET    0x4
 #define NFP_NET_CFG_MBOX_SIMPLE_VAL    0x8
-#define NFP_NET_CFG_MBOX_SIMPLE_LEN    0x12
+#define NFP_NET_CFG_MBOX_SIMPLE_LEN    12
 
 #define NFP_NET_CFG_MBOX_CMD_CTAG_FILTER_ADD 1
 #define NFP_NET_CFG_MBOX_CMD_CTAG_FILTER_KILL 2