]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: qcom: camss: Fix csid IRQ offset for sa8775p
authorWenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Fri, 13 Mar 2026 10:13:02 +0000 (18:13 +0800)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 27 Apr 2026 06:41:22 +0000 (08:41 +0200)
Fix BUF_DONE_IRQ_STATUS_RDI_OFFSET calculation for csid lite on
sa8775p platform. The offset should be 0 for csid lite on sa8775p,

Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Fixes: ed03e99de0fa ("media: qcom: camss: Add support for CSID 690")
Cc: stable@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/qcom/camss/camss-csid-gen3.c

index 664245cf6eb0cac662b02f8b920cd1c72db0aeb2..bd059243790edeb045080905eb76fef3b12caae1 100644 (file)
@@ -48,9 +48,9 @@
 #define IS_CSID_690(csid)      ((csid->camss->res->version == CAMSS_8775P) \
                                 || (csid->camss->res->version == CAMSS_8300))
 #define CSID_BUF_DONE_IRQ_STATUS       0x8C
-#define BUF_DONE_IRQ_STATUS_RDI_OFFSET  (csid_is_lite(csid) ?\
-                                               1 : (IS_CSID_690(csid) ?\
-                                               13 : 14))
+#define BUF_DONE_IRQ_STATUS_RDI_OFFSET  (csid_is_lite(csid) ? \
+                                               ((IS_CSID_690(csid) ? 0 : 1)) : \
+                                               ((IS_CSID_690(csid) ? 13 : 14)))
 #define CSID_BUF_DONE_IRQ_MASK         0x90
 #define CSID_BUF_DONE_IRQ_CLEAR                0x94
 #define CSID_BUF_DONE_IRQ_SET          0x98