]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli:nbt: Initialize struct nbt_name_register
authorAndreas Schneider <asn@samba.org>
Fri, 5 Jul 2024 12:00:11 +0000 (14:00 +0200)
committerGünther Deschner <gd@samba.org>
Tue, 16 Jul 2024 11:41:33 +0000 (11:41 +0000)
"Error: UNINIT (CWE-457):
samba-4.20.0rc2/libcli/nbt/pynbt.c:277: var_decl: Declaring variable ""io"" without initializer.
samba-4.20.0rc2/libcli/nbt/pynbt.c:305: uninit_use_in_call: Using uninitialized value ""io.in.nb_flags"" when calling ""nbt_name_register"".
  303|    return NULL;
  304|
  305|->  status = nbt_name_register(node->socket, NULL, &io);
  306|
  307|    if (NT_STATUS_IS_ERR(status)) {"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
libcli/nbt/pynbt.c

index e0a72fa845157b7dbc9da8db47c633586780afbd..18ae369b69557bb9d4d5472c2701d87519899688 100644 (file)
@@ -141,7 +141,7 @@ err:
        return false;
 }
 
-static PyObject *PyObject_FromNBTName(struct nbt_name_socket *name_socket, 
+static PyObject *PyObject_FromNBTName(struct nbt_name_socket *name_socket,
                                      struct nbt_name *name)
 {
        if (name->scope) {
@@ -274,7 +274,7 @@ static PyObject *py_nbt_name_register(PyObject *self, PyObject *args, PyObject *
 {
        nbt_node_Object *node = (nbt_node_Object *)self;
        PyObject *ret, *py_dest, *py_name;
-       struct nbt_name_register io;
+       struct nbt_name_register io = {};
        NTSTATUS status;
 
        const char *kwnames[] = { "name", "address", "dest", "register_demand", "broadcast",