]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
core: downgrade legit error logs (#5705)
authorumuttl <umut@tezduyar.com>
Mon, 10 Apr 2017 11:12:25 +0000 (13:12 +0200)
committerLennart Poettering <lennart@poettering.net>
Mon, 10 Apr 2017 11:12:25 +0000 (13:12 +0200)
manager_sync_bus_names() function retrieves the dbus names
and compares it with unit bus names. It could be right
after the list is retrieved, the dbus peer is disconnected.
In this case it is really not an ERROR print if
sd_bus_get_name_creds() or sd_bus_creds_get_unique_name()
fail.

src/core/dbus.c

index 065f2d81d6575d34425ae5e3fd1bdd063ccff187..cfc045d282c72ed5069f2fe4a8c6e3caeef67f43 100644 (file)
@@ -753,13 +753,13 @@ int manager_sync_bus_names(Manager *m, sd_bus *bus) {
                         /* If it is, determine its current owner */
                         r = sd_bus_get_name_creds(bus, name, SD_BUS_CREDS_UNIQUE_NAME, &creds);
                         if (r < 0) {
-                                log_error_errno(r, "Failed to get bus name owner %s: %m", name);
+                                log_full_errno(r == -ENXIO ? LOG_DEBUG : LOG_ERR, r, "Failed to get bus name owner %s: %m", name);
                                 continue;
                         }
 
                         r = sd_bus_creds_get_unique_name(creds, &unique);
                         if (r < 0) {
-                                log_error_errno(r, "Failed to get unique name for %s: %m", name);
+                                log_full_errno(r == -ENXIO ? LOG_DEBUG : LOG_ERR, r, "Failed to get unique name for %s: %m", name);
                                 continue;
                         }