Raise more correct exception on overflow in setting buffer_size attribute of

expat parser.

diff --git a/Lib/test/test_pyexpat.py b/Lib/test/test_pyexpat.py
index 7548924e0f8c7d1d0df57bd92edf7995deb47f59..216a46b903e0b1455de9d9c14c2929132a430753 100644 (file)
--- a/Lib/test/test_pyexpat.py
+++ b/Lib/test/test_pyexpat.py
@@ -3,6 +3,7 @@
 
 from io import BytesIO
 import os
+import sys
 import sysconfig
 import unittest
 import traceback
@@ -543,6 +544,8 @@ class ChardataBufferTest(unittest.TestCase):
             parser.buffer_size = -1
         with self.assertRaises(ValueError):
             parser.buffer_size = 0
+        with self.assertRaises((ValueError, OverflowError)):
+            parser.buffer_size = sys.maxsize + 1
         with self.assertRaises(TypeError):
             parser.buffer_size = 512.0
 

diff --git a/Modules/pyexpat.c b/Modules/pyexpat.c
index c4fdaafb86043e4a7ee03204d2e3b252e6e3ec52..6a901f756cabfc7d52ae727017044b5c431190d1 100644 (file)
--- a/Modules/pyexpat.c
+++ b/Modules/pyexpat.c
@@ -1403,17 +1403,18 @@ xmlparse_setattro(xmlparseobject *self, PyObject *name, PyObject *v)
         return -1;
       }
 
-      new_buffer_size=PyLong_AS_LONG(v);
+      new_buffer_size = PyLong_AsLong(v);
+      if (new_buffer_size <= 0) {
+        if (!PyErr_Occurred())
+          PyErr_SetString(PyExc_ValueError, "buffer_size must be greater than zero");
+        return -1;
+      }
+
       /* trivial case -- no change */
       if (new_buffer_size == self->buffer_size) {
         return 0;
       }
 
-      if (new_buffer_size <= 0) {
-        PyErr_SetString(PyExc_ValueError, "buffer_size must be greater than zero");
-        return -1;
-      }
-
       /* check maximum */
       if (new_buffer_size > INT_MAX) {
         char errmsg[100];