]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
NFSD: Replace READ* macros that decode the fattr4 owner attribute
authorChuck Lever <chuck.lever@oracle.com>
Thu, 19 Nov 2020 18:56:42 +0000 (13:56 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Jun 2024 12:52:35 +0000 (14:52 +0200)
[ Upstream commit 9853a5ac9be381917e9be0b4133cd4ac5a7ad875 ]

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfsd/nfs4xdr.c

index 9dc73ab95eac9bbdc71c7b1cb2aa3ad5a0015014..7dc6b79e51fd0dc0ad144806ad7ff1c4ed9cdadc 100644 (file)
@@ -360,11 +360,16 @@ nfsd4_decode_fattr(struct nfsd4_compoundargs *argp, u32 *bmval,
                iattr->ia_valid |= ATTR_MODE;
        }
        if (bmval[1] & FATTR4_WORD1_OWNER) {
-               READ_BUF(4);
-               dummy32 = be32_to_cpup(p++);
-               READ_BUF(dummy32);
-               READMEM(buf, dummy32);
-               if ((status = nfsd_map_name_to_uid(argp->rqstp, buf, dummy32, &iattr->ia_uid)))
+               u32 length;
+
+               if (xdr_stream_decode_u32(argp->xdr, &length) < 0)
+                       return nfserr_bad_xdr;
+               p = xdr_inline_decode(argp->xdr, length);
+               if (!p)
+                       return nfserr_bad_xdr;
+               status = nfsd_map_name_to_uid(argp->rqstp, (char *)p, length,
+                                             &iattr->ia_uid);
+               if (status)
                        return status;
                iattr->ia_valid |= ATTR_UID;
        }