]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-100098: [Enum] insist on actual tuples, no subclasses, for auto (GH-100099)
authorEthan Furman <ethan@stoneleaf.us>
Thu, 8 Dec 2022 06:58:08 +0000 (22:58 -0800)
committerGitHub <noreply@github.com>
Thu, 8 Dec 2022 06:58:08 +0000 (22:58 -0800)
When checking for auto() instances, only top-level usage is supported,
which means either alone or as part of a regular tuple. Other
containers, such as lists, dicts, or namedtuples, will not have auto()
transformed into a value.

Lib/enum.py
Lib/test/test_enum.py
Misc/NEWS.d/next/Library/2022-12-08-06-18-06.gh-issue-100098.uBvPlp.rst [new file with mode: 0644]

index b2f7b9f8d4ad1356c5899379cca49c5bea085c42..a0cad066dc23f71b1a593e79a4c07cd506efccfa 100644 (file)
@@ -436,7 +436,9 @@ class _EnumDict(dict):
             if isinstance(value, auto):
                 single = True
                 value = (value, )
-            if isinstance(value, tuple):
+            if type(value) is tuple and any(isinstance(v, auto) for v in value):
+                # insist on an actual tuple, no subclasses, in keeping with only supporting
+                # top-level auto() usage (not contained in any other data structure)
                 auto_valued = []
                 for v in value:
                     if isinstance(v, auto):
index 376347e4c111de9a70e6cf13c8738ca651b64ec2..d876c8e5fb7798f63c3e854ab1b611b91985ef76 100644 (file)
@@ -2841,6 +2841,19 @@ class TestSpecial(unittest.TestCase):
         self.assertEqual(deep, flags)
         self.assertEqual(copied.value, 1 | 2 | 8)
 
+    def test_namedtuple_as_value(self):
+        from collections import namedtuple
+        TTuple = namedtuple('TTuple', 'id a blist')
+        class NTEnum(Enum):
+            NONE = TTuple(0, 0, [])
+            A = TTuple(1, 2, [4])
+            B = TTuple(2, 4, [0, 1, 2])
+        self.assertEqual(repr(NTEnum.NONE), "<NTEnum.NONE: TTuple(id=0, a=0, blist=[])>")
+        self.assertEqual(NTEnum.NONE.value, TTuple(id=0, a=0, blist=[]))
+        self.assertEqual(
+                [x.value for x in NTEnum],
+                [TTuple(id=0, a=0, blist=[]), TTuple(id=1, a=2, blist=[4]), TTuple(id=2, a=4, blist=[0, 1, 2])],
+                )
 
 class TestOrder(unittest.TestCase):
     "test usage of the `_order_` attribute"
diff --git a/Misc/NEWS.d/next/Library/2022-12-08-06-18-06.gh-issue-100098.uBvPlp.rst b/Misc/NEWS.d/next/Library/2022-12-08-06-18-06.gh-issue-100098.uBvPlp.rst
new file mode 100644 (file)
index 0000000..256f2bc
--- /dev/null
@@ -0,0 +1 @@
+Fix ``tuple`` subclasses being cast to ``tuple`` when used as enum values.