]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
Don't play with free()'d pointers
authorPaul Cadach <paul@odt.east.telecom.kz>
Tue, 30 Jan 2007 08:34:26 +0000 (08:34 +0000)
committerPaul Cadach <paul@odt.east.telecom.kz>
Tue, 30 Jan 2007 08:34:26 +0000 (08:34 +0000)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52808 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_odbc.c

index e87190090165bdd38ca75743eea91c16f142600c..34f012de683bdef1383cc36cc3cc7c5be6b7c09f 100644 (file)
@@ -360,7 +360,8 @@ static int odbc_register_class(struct odbc_class *class, int connect)
                if (connect) {
                        /* Request and release builds a connection */
                        obj = ast_odbc_request_obj(class->name, 0);
-                       ast_odbc_release_obj(obj);
+                       if (obj)
+                               ast_odbc_release_obj(obj);
                }
 
                return 0;
@@ -431,9 +432,10 @@ struct odbc_obj *ast_odbc_request_obj(const char *name, int check)
                        ast_mutex_init(&obj->lock);
                        obj->parent = class;
                        if (odbc_obj_connect(obj) == ODBC_FAIL) {
-                               ast_log(LOG_WARNING, "Failed to connect\n");
+                               ast_log(LOG_WARNING, "Failed to connect to %s\n", name);
                                ast_mutex_destroy(&obj->lock);
                                free(obj);
+                               obj = NULL;
                        } else {
                                AST_LIST_INSERT_HEAD(&class->odbc_obj, obj, list);
                        }