]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: typec: tcpm: Correct port source pdo array in pd_set callback
authorKyle Tso <kyletso@google.com>
Mon, 11 Mar 2024 14:45:00 +0000 (22:45 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Apr 2024 13:32:47 +0000 (15:32 +0200)
commit 893cd9469c68a89a34956121685617dbb37497b1 upstream.

In tcpm_pd_set, the array of port source capabilities is port->src_pdo,
not port->snk_pdo.

Fixes: cd099cde4ed2 ("usb: typec: tcpm: Support multiple capabilities")
Cc: stable@vger.kernel.org
Signed-off-by: Kyle Tso <kyletso@google.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240311144500.3694849-1-kyletso@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpm.c

index 7dd521e48684a11fc707e2d8248f2bc2a8a90cdb..3b38f7f5d57c5e5489a6d0ba555a614ce159abb6 100644 (file)
@@ -6117,7 +6117,7 @@ static int tcpm_pd_set(struct typec_port *p, struct usb_power_delivery *pd)
 
        if (data->source_desc.pdo[0]) {
                for (i = 0; i < PDO_MAX_OBJECTS && data->source_desc.pdo[i]; i++)
-                       port->snk_pdo[i] = data->source_desc.pdo[i];
+                       port->src_pdo[i] = data->source_desc.pdo[i];
                port->nr_src_pdo = i + 1;
        }