]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panthor: Fix the "done_fence is initialized" detection logic
authorBoris Brezillon <boris.brezillon@collabora.com>
Mon, 9 Mar 2026 12:43:18 +0000 (13:43 +0100)
committerSteven Price <steven.price@arm.com>
Wed, 11 Mar 2026 08:50:35 +0000 (08:50 +0000)
After commit 541c8f2468b9 ("dma-buf: detach fence ops on signal v3"),
dma_fence::ops == NULL can't be used to check if the fence is initialized.
Use dma_fence_was_initialized() instead.

v2:
- Use dma_fence_was_initialized() instead of open-coding it

Cc: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Philipp Stanner <phasta@kernel.org>
Cc: Christian König <christian.koenig@amd.com>
Reported-by: Steven Price <steven.price@arm.com>
Reported-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Fixes: 541c8f2468b9 ("dma-buf: detach fence ops on signal v3")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patch.msgid.link/20260309124318.222902-1-boris.brezillon@collabora.com
drivers/gpu/drm/panthor/panthor_sched.c

index bd703a2904a168ca46e20ec80fd08126d23e20c7..c15941ebe07ad30ffa231ce35f044fe3a4298acf 100644 (file)
@@ -3915,7 +3915,7 @@ static void job_release(struct kref *ref)
        if (job->base.s_fence)
                drm_sched_job_cleanup(&job->base);
 
-       if (job->done_fence && job->done_fence->ops)
+       if (dma_fence_was_initialized(job->done_fence))
                dma_fence_put(job->done_fence);
        else
                dma_fence_free(job->done_fence);