]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
core/execute: use assertion for _done function 30543/head
authorMike Yuan <me@yhndnzj.com>
Wed, 20 Dec 2023 13:56:49 +0000 (21:56 +0800)
committerMike Yuan <me@yhndnzj.com>
Wed, 20 Dec 2023 13:56:49 +0000 (21:56 +0800)
As per our usual coding style.

src/core/execute.c

index 3b223a3aceda50c861c8a15e566d746a8cc89fd8..da55ef0564b77ed7d6ced15695f9c0583460f011 100644 (file)
@@ -1955,8 +1955,7 @@ static char *destroy_tree(char *path) {
 }
 
 void exec_shared_runtime_done(ExecSharedRuntime *rt) {
-        if (!rt)
-                return;
+        assert(rt);
 
         if (rt->manager)
                 (void) hashmap_remove(rt->manager->exec_shared_runtime_by_id, rt->id);
@@ -1969,8 +1968,10 @@ void exec_shared_runtime_done(ExecSharedRuntime *rt) {
 }
 
 static ExecSharedRuntime* exec_shared_runtime_free(ExecSharedRuntime *rt) {
-        exec_shared_runtime_done(rt);
+        if (!rt)
+                return NULL;
 
+        exec_shared_runtime_done(rt);
         return mfree(rt);
 }