]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
negotiate_wrapper: Fix bad pointer comparisons in rev.14290
authorAmos Jeffries <squid3@treenet.co.nz>
Thu, 1 Oct 2015 12:22:44 +0000 (05:22 -0700)
committerAmos Jeffries <squid3@treenet.co.nz>
Thu, 1 Oct 2015 12:22:44 +0000 (05:22 -0700)
 Detected by Coverity Scan. Issues 1324560132456113245621324563

helpers/negotiate_auth/wrapper/negotiate_wrapper.cc

index 705820eb0f676531d9e85cb689430072dbae7ab4..4d359c0cbc6fca47d8152744a3226afd7f24921e 100644 (file)
@@ -95,13 +95,13 @@ void usage(void)
 static void
 closeFds(FILE *a, FILE *b, FILE *c, FILE *d)
 {
-    if (a >= 0)
+    if (a)
         fclose(a);
-    if (b >= 0)
+    if (b)
         fclose(b);
-    if (c >= 0)
+    if (c)
         fclose(c);
-    if (d >= 0)
+    if (d)
         fclose(d);
 }