hs: Fix memory leak if service failed to configure

Closes #40484

Signed-off-by: David Goulet <dgoulet@torproject.org>

diff --git a/changes/ticket40484 b/changes/ticket40484
new file mode 100644 (file)
index 0000000..9a9ffdf
--- /dev/null
+++ b/changes/ticket40484
@@ -0,0 +1,5 @@
+  o Minor bugfixes (onion service, config):
+    - Fix a memory leak for a small config line string that could occur if the
+      service failed to be configured from file properly. Fixes bug 40484;
+      bugfix on 0.3.2.1-alpha.
+

diff --git a/src/feature/hs/hs_config.c b/src/feature/hs/hs_config.c
index f9f71c78f2c5843ff9a8b14c01e2a91617d94a3c..de1f608ddf0106666ebd324a7aa622dca50d55c4 100644 (file)
--- a/src/feature/hs/hs_config.c
+++ b/src/feature/hs/hs_config.c
@@ -640,6 +640,7 @@ hs_config_service_all(const or_options_t *options, int validate_only)
     int rv = config_service(section, options, new_service_list);
     config_free_lines(section);
     if (rv < 0) {
+      config_free_lines(remaining);
       goto err;
     }
   }