]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/rockchip: lvds: do not print scary message when probing defer
authorQuentin Schulz <quentin.schulz@theobroma-systems.com>
Mon, 20 Nov 2023 12:29:49 +0000 (13:29 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:21:55 +0000 (18:21 -0400)
[ Upstream commit 52d11c863ac92e36a0365249f7f6d27ac48c78bc ]

This scary message can misled the user into thinking something bad has
happened and needs to be fixed, however it could simply be part of a
normal boot process where EPROBE_DEFER is taken into account. Therefore,
let's use dev_err_probe so that this message doesn't get shown (by
default) when the return code is EPROBE_DEFER.

Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Cc: Quentin Schulz <foss+kernel@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231120-rk-lvds-defer-msg-v2-2-9c59a5779cf9@theobroma-systems.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/rockchip/rockchip_lvds.c

index 1ffb2f710e4bd9efe0f48c9fb84abd9c957b56b9..96c13c182809e6198152611826485eae6e09d1a4 100644 (file)
@@ -572,7 +572,7 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master,
                ret = -EINVAL;
                goto err_put_port;
        } else if (ret) {
-               DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n");
+               dev_err_probe(dev, ret, "failed to find panel and bridge node\n");
                goto err_put_port;
        }
        if (lvds->panel)