]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
fsck: fix clang compiler warning
authorSami Kerola <kerolasa@iki.fi>
Thu, 24 Feb 2011 19:15:43 +0000 (20:15 +0100)
committerKarel Zak <kzak@redhat.com>
Tue, 8 Mar 2011 10:49:55 +0000 (11:49 +0100)
fsck.c:874:22: warning: format string is not a string literal
      (potentially insecure) [-Wformat-security]
errx(EXIT_USAGE, _(fs_type_syntax_error));
 ^~~~~~~~~~~~~~~~~~~~~~~

The issue was introduced in my commit 0a09eb4e, sorry.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
fsck/fsck.c

index effc866f359684c8992089b31a368925c4a76c2f..0d5fedac261c726daf38d8997237d84e4b2ec537 100644 (file)
@@ -819,10 +819,6 @@ struct fs_type_compile {
 #define FS_TYPE_OPT    1
 #define FS_TYPE_NEGOPT 2
 
-static const char *fs_type_syntax_error =
-N_("Either all or none of the filesystem types passed to -t must be prefixed\n"
-   "with 'no' or '!'.\n");
-
 static void compile_fs_type(char *fs_type, struct fs_type_compile *cmp)
 {
        char    *cp, *list, *s;
@@ -871,7 +867,9 @@ static void compile_fs_type(char *fs_type, struct fs_type_compile *cmp)
                        }
                        if ((negate && !cmp->negate) ||
                            (!negate && cmp->negate)) {
-                               errx(EXIT_USAGE, _(fs_type_syntax_error));
+                               errx(EXIT_USAGE,
+                                       _("Either all or none of the filesystem types passed to -t must be prefixed\n"
+                                         "with 'no' or '!'."));
                        }
                }
 #if 0