]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
net: phy: Fix return value check phy_probe
authorSiva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
Tue, 26 Feb 2019 12:12:43 +0000 (17:42 +0530)
committerMichal Simek <michal.simek@xilinx.com>
Wed, 27 Feb 2019 07:53:11 +0000 (08:53 +0100)
Don't ignore return value of phy_probe() call as
the probe may fail and it needs to be reported.

Signed-off-by: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/net/phy/phy.c

index 0b3388eaa543ee2ba7e9d232faa88ee030a9eaa2..2017f595683a4a1a6be63f4e509a00412bbb9b06 100644 (file)
@@ -669,7 +669,10 @@ static struct phy_device *phy_device_create(struct mii_dev *bus, int addr,
 
        dev->drv = get_phy_driver(dev, interface);
 
-       phy_probe(dev);
+       if (phy_probe(dev)) {
+               printf("%s, PHY probe failed\n", __func__);
+               return NULL;
+       }
 
        if (addr >= 0 && addr < PHY_MAX_ADDR)
                bus->phymap[addr] = dev;