]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
mountpoint-util: add comment explaining why fstype_can_discard() can't use mount_opti... 26704/head
authorLennart Poettering <lennart@poettering.net>
Tue, 7 Mar 2023 11:21:10 +0000 (12:21 +0100)
committerLennart Poettering <lennart@poettering.net>
Thu, 9 Mar 2023 20:56:42 +0000 (21:56 +0100)
src/basic/mountpoint-util.c

index 2cb319ba649a675ec520b6183e4fc24ea114e87b..e285702388a8f7e49f27c382ea8a6b71d768c865 100644 (file)
@@ -509,9 +509,11 @@ bool fstype_can_umask(const char *fstype) {
 }
 
 bool fstype_can_uid_gid(const char *fstype) {
-
-        /* All file systems that have a uid=/gid= mount option that fixates the owners of all files and directories,
-         * current and future. */
+        /* All file systems that have a uid=/gid= mount option that fixates the owners of all files and
+         * directories, current and future. Note that this does *not* ask the kernel via
+         * mount_option_supported() here because the uid=/gid= setting of various file systems mean different
+         * things: some apply it only to the root dir inode, others to all inodes in the file system. Thus we
+         * maintain the curated list below. ðŸ˜¢ */
 
         return STR_IN_SET(fstype,
                           "adfs",