]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
platform/chrome: cros_ec_debugfs: fix wrong EC message version
authorTzung-Bi Shih <tzungbi@kernel.org>
Tue, 11 Jun 2024 11:31:10 +0000 (11:31 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Aug 2024 06:59:10 +0000 (08:59 +0200)
[ Upstream commit c2a28647bbb4e0894e8824362410f72b06ac57a4 ]

ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it
wrongly uses message version 0.

Fix it.

Fixes: e86264595225 ("mfd: cros_ec: add debugfs, console log file")
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Link: https://lore.kernel.org/r/20240611113110.16955-1-tzungbi@kernel.org
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/chrome/cros_ec_debugfs.c

index e1d313246beb5a0dd9b709c70c4814606c59e18d..5996e9d53c387896c5183d5d2ec8d3d4c95f6064 100644 (file)
@@ -330,6 +330,7 @@ static int ec_read_version_supported(struct cros_ec_dev *ec)
        if (!msg)
                return 0;
 
+       msg->version = 1;
        msg->command = EC_CMD_GET_CMD_VERSIONS + ec->cmd_offset;
        msg->outsize = sizeof(*params);
        msg->insize = sizeof(*response);