]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Aug 2022 15:36:44 +0000 (17:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Aug 2022 15:36:44 +0000 (17:36 +0200)
added patches:
bluetooth-l2cap-fix-l2cap_global_chan_by_psm-regression.patch

queue-5.19/bluetooth-l2cap-fix-l2cap_global_chan_by_psm-regression.patch [new file with mode: 0644]
queue-5.19/series

diff --git a/queue-5.19/bluetooth-l2cap-fix-l2cap_global_chan_by_psm-regression.patch b/queue-5.19/bluetooth-l2cap-fix-l2cap_global_chan_by_psm-regression.patch
new file mode 100644 (file)
index 0000000..3d0beba
--- /dev/null
@@ -0,0 +1,56 @@
+From 332f1795ca202489c665a75e62e18ff6284de077 Mon Sep 17 00:00:00 2001
+From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
+Date: Mon, 1 Aug 2022 13:52:07 -0700
+Subject: Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm regression
+
+From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
+
+commit 332f1795ca202489c665a75e62e18ff6284de077 upstream.
+
+The patch d0be8347c623: "Bluetooth: L2CAP: Fix use-after-free caused
+by l2cap_chan_put" from Jul 21, 2022, leads to the following Smatch
+static checker warning:
+
+        net/bluetooth/l2cap_core.c:1977 l2cap_global_chan_by_psm()
+        error: we previously assumed 'c' could be null (see line 1996)
+
+Fixes: d0be8347c623 ("Bluetooth: L2CAP: Fix use-after-free caused by l2cap_chan_put")
+Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
+Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/bluetooth/l2cap_core.c |   13 ++++++-------
+ 1 file changed, 6 insertions(+), 7 deletions(-)
+
+--- a/net/bluetooth/l2cap_core.c
++++ b/net/bluetooth/l2cap_core.c
+@@ -1969,11 +1969,11 @@ static struct l2cap_chan *l2cap_global_c
+                                                  bdaddr_t *dst,
+                                                  u8 link_type)
+ {
+-      struct l2cap_chan *c, *c1 = NULL;
++      struct l2cap_chan *c, *tmp, *c1 = NULL;
+       read_lock(&chan_list_lock);
+-      list_for_each_entry(c, &chan_list, global_l) {
++      list_for_each_entry_safe(c, tmp, &chan_list, global_l) {
+               if (state && c->state != state)
+                       continue;
+@@ -1992,11 +1992,10 @@ static struct l2cap_chan *l2cap_global_c
+                       dst_match = !bacmp(&c->dst, dst);
+                       if (src_match && dst_match) {
+                               c = l2cap_chan_hold_unless_zero(c);
+-                              if (!c)
+-                                      continue;
+-
+-                              read_unlock(&chan_list_lock);
+-                              return c;
++                              if (c) {
++                                      read_unlock(&chan_list_lock);
++                                      return c;
++                              }
+                       }
+                       /* Closest match */
index f329ac5fec77a7d7272e0487d58e5f2f792db1e9..5cc86036891f4b79fd7b901f41ab1d4657727283 100644 (file)
@@ -1155,3 +1155,4 @@ net-dsa-felix-fix-min-gate-len-calculation-for-tc-when-its-first-gate-is-closed.
 revert-s390-smp-enforce-lowcore-protection-on-cpu-restart.patch
 powerpc-kexec-fix-build-failure-from-uninitialised-variable.patch
 io_uring-mem-account-pbuf-buckets.patch
+bluetooth-l2cap-fix-l2cap_global_chan_by_psm-regression.patch