]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdb: Fix CID 1353176 Logically dead code
authorVolker Lendecke <vl@samba.org>
Tue, 16 Feb 2016 10:18:40 +0000 (11:18 +0100)
committerMichael Adam <obnox@samba.org>
Tue, 16 Feb 2016 15:41:18 +0000 (16:41 +0100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
ctdb/server/ipalloc_common.c

index c84359b2db9b43dc3fe74cfe17119ed29022659a..95d5ecf0c2127d9052e6e624ab80305c89b9150b 100644 (file)
@@ -65,13 +65,12 @@ static bool can_node_host_ip(struct ipalloc_state *ipalloc_state,
        if (ipalloc_state->noiphost[pnn]) {
                return false;
        }
-
-       public_ips = &ipalloc_state->available_public_ips[pnn];
-
-       if (public_ips == NULL) {
+       if (ipalloc_state->available_public_ips == NULL) {
                return false;
        }
 
+       public_ips = &ipalloc_state->available_public_ips[pnn];
+
        for (i=0; i<public_ips->num; i++) {
                if (ctdb_same_ip(&ip->addr, &public_ips->ip[i].addr)) {
                        /* yes, this node can serve this public ip */