]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clocksource/drivers/nxp-pit: Prevent driver unbind
authorJohan Hovold <johan@kernel.org>
Tue, 11 Nov 2025 15:32:25 +0000 (16:32 +0100)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Wed, 26 Nov 2025 10:24:57 +0000 (11:24 +0100)
The driver does not support unbinding (e.g. as clockevents cannot be
deregistered) so suppress the bind attributes to prevent the driver from
being unbound and rebound after registration (and disabling the timer
when reprobing fails).

Even if the driver can currently only be built-in, also switch to
builtin_platform_driver() to prevent it from being unloaded should
modular builds ever be enabled.

Fixes: bee33f22d7c3 ("clocksource/drivers/nxp-pit: Add NXP Automotive s32g2 / s32g3 support")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://patch.msgid.link/20251111153226.579-3-johan@kernel.org
drivers/clocksource/timer-nxp-pit.c

index 2d0a3554b6bf7d69f9ce9d1a95556442b9a1f718..d1740f18f718032e65bf08827357ea5934194570 100644 (file)
@@ -374,9 +374,10 @@ static struct platform_driver nxp_pit_driver = {
        .driver = {
                .name = "nxp-pit",
                .of_match_table = pit_timer_of_match,
+               .suppress_bind_attrs = true,
        },
        .probe = pit_timer_probe,
 };
-module_platform_driver(nxp_pit_driver);
+builtin_platform_driver(nxp_pit_driver);
 
 TIMER_OF_DECLARE(vf610, "fsl,vf610-pit", pit_timer_init);