[1512] test different name hash values for a known pair.

added comments about the underlying assumption and what we should do
if that isn't held.

diff --git a/src/lib/dns/python/tests/name_python_test.py b/src/lib/dns/python/tests/name_python_test.py
index b3b6e6a14ddb3bd689c6127efc0fee2b0d162280..8ea2e3520a1006b04e9676b21d4403e05a90f01e 100644 (file)
--- a/src/lib/dns/python/tests/name_python_test.py
+++ b/src/lib/dns/python/tests/name_python_test.py
@@ -223,8 +223,19 @@ class NameTest(unittest.TestCase):
         self.assertEqual(hash(Name('example.com')), hash(Name('example.com')))
         # Hash is case insensitive.
         self.assertEqual(hash(Name('example.com')), hash(Name('EXAMPLE.COM')))
-        # We cannot reliably test the case for different hash values, but
-        # we can at least confirm inequality is case insensitive.
+
+        # These pairs happen to be known to have different hashes.
+        # It may be naive to assume the hash value is always the same (we use
+        # an external library and it depends on its internal details).  If
+        # it turns out that this assumption isn't always held, we should
+        # disable this test.
+        self.assertNotEqual(hash(Name('example.com')),
+                            hash(Name('example.org')))
+
+        # Check insensitiveness for the case of inequality.
+        # Based on the assumption above, this 'if' should be true and
+        # we'll always test the case inside it.  We'll still keep the if in
+        # case we end up disabling the above test.
         if hash(Name('example.com')) != hash(Name('example.org')):
             self.assertNotEqual(hash(Name('example.com')),
                                 hash(Name('EXAMPLE.ORG')))