chan_sip: fix Local From tag on outbound register regression

In ASTERISK-12117, an improvement to insure consistant local from tags
on outbound registrations resulted in an undesirable behavior - caused
by leftover unexpired sip_pvt dialogs (with the previous cseq number),
resulting in many uncessary REGISTER requests.  Instead of significant
rework of transmit_register(), this change deletes the dialogs after a
200 OK response indiciating a successful registration, keeping the old
dialogs from interfering with normal operation.

(closes issue ASTERISK-22946)
Reported by: Stephan Eisvogel
Review: https://reviewboard.asterisk.org/r/3109/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@405433 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index cb174da45aa717c03a26a3a1f703094104a33d0b..b61ebdf7ce29ce1e87ba1df914ca2fc003ce2631 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -13847,7 +13847,7 @@ static int transmit_register(struct sip_registry *r, int sipmethod, const char *
 
                /* reset tag to consistent value from registry */
                ast_string_field_set(p, tag, r->localtag);
-               
+
                if (p->do_history) {
                        append_history(p, "RegistryInit", "Account: %s@%s", r->username, r->hostname);
                }
@@ -21541,9 +21541,9 @@ static int handle_response_register(struct sip_pvt *p, int resp, const char *res
                if (r->call)
                        r->call = dialog_unref(r->call, "unsetting registry->call pointer-- case 200");
                p->registry = registry_unref(p->registry, "unref registry entry p->registry");
-               /* Let this one hang around until we have all the responses */
-               sip_scheddestroy(p, DEFAULT_TRANS_TIMEOUT);
-               /* p->needdestroy = 1; */
+
+               /* destroy dialog now to avoid interference with next register */
+               pvt_set_needdestroy(p, "Registration successfull");
                
                /* set us up for re-registering
                 * figure out how long we got registered for