]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mailbox: mpfs: fix check for syscon presence in mpfs_mbox_inbox_isr()
authorConor Dooley <conor.dooley@microchip.com>
Thu, 14 May 2026 16:39:51 +0000 (17:39 +0100)
committerJassi Brar <jassisinghbrar@gmail.com>
Mon, 18 May 2026 18:22:58 +0000 (13:22 -0500)
mpfs_mbox_inbox_isr() writes to the sysreg scb syscon, not the control
scb syscon, but checks for the presence of the latter. Ultimately this
makes little difference because if one syscon is present, both will be.

Fixes: a4123ffab9ece ("mailbox: mpfs: support new, syscon based, devicetree configuration")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/mailbox-mpfs.c

index d5d9effece9797e3423e69e805a3cdda60132731..ef40fe2be30d653456141067b382b02e2c785c17 100644 (file)
@@ -201,7 +201,7 @@ static irqreturn_t mpfs_mbox_inbox_isr(int irq, void *data)
        struct mbox_chan *chan = data;
        struct mpfs_mbox *mbox = (struct mpfs_mbox *)chan->con_priv;
 
-       if (mbox->control_scb)
+       if (mbox->sysreg_scb)
                regmap_write(mbox->sysreg_scb, MESSAGE_INT_OFFSET, 0);
        else
                writel_relaxed(0, mbox->int_reg);