use the new CH_UTF16_MUNGED charset for utf16 password buffers

now to work out how to test this ...

diff --git a/source4/dsdb/samdb/ldb_modules/password_hash.c b/source4/dsdb/samdb/ldb_modules/password_hash.c
index fc8fb775eeaa1eeb08f6cad54453d7385abbfccf..cef1bf79f74b58f9345f89653646f93110978f02 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/password_hash.c
+++ b/source4/dsdb/samdb/ldb_modules/password_hash.c
@@ -1338,7 +1338,7 @@ static int setup_password_fields(struct setup_password_fields_io *io)
                        return LDB_ERR_OPERATIONS_ERROR;
                }
                converted_pw_len = convert_string_talloc_convenience(io->ac, lp_iconv_convenience(ldb_get_opaque(io->ac->module->ldb, "loadparm")), 
-                                                        CH_UTF16, CH_UTF8, io->n.cleartext_utf16->data, io->n.cleartext_utf16->length, 
+                                                        CH_UTF16MUNGED, CH_UTF8, io->n.cleartext_utf16->data, io->n.cleartext_utf16->length, 
                                                         (void **)&cleartext_utf8_str);
                if (converted_pw_len == -1) {
                        /* We can't bail out entirely, as these unconvertable passwords are frustratingly valid */